android_new: fix force_build option#1006
android_new: fix force_build option#1006AndreMiras merged 1 commit intokivy:masterfrom ZingBallyhoo:force_build_fix
Conversation
inclement
left a comment
inclement
left a comment
There was a problem hiding this comment.
Looks good, thanks! I'll merge it once I've tested it.
Did you check that the force_build option works? Although the get_distribution function handles it, I can't remember if it actually will behave the right way under all circumstances. I'll try to check this as well.
| join(self.ctx.get_python_install_dir(), 'bin', 'python.host')) | ||
| self.ctx.hostpython = join(self.ctx.get_python_install_dir(), 'bin', 'python.host') | ||
|
|
||
| if isfile(join(self.ctx.get_python_install_dir(), 'bin', 'python.host')): |
There was a problem hiding this comment.
Am I right in reading that the only change here is skipping the copy if the target already exists? If so, it would be preferable to clean it up a little more and put only the sh.cp call in the if block.
There was a problem hiding this comment.
Should be better now
|
@inclement AFAIK the option is working fine, as I am currently using it. |
|
@inclement |
|
I tested and was going to merge this but actually found that the formatting changes create a lot of unnecessarily long lines, in some places removing existing line breaks. Would you be interested in splitting this into a separate force_build fix and a formatting PR? Alternatively, I can pull the force_build fix out manually. |
|
@inclement Only the fix for |
|
Hi @ZingBallyhoo I'm really sorry we didn't make it to the tree and now the PR is conflicting 😢 |
|
I've rebased to master and squashed the commit. |
3 participants
In current master, the
force-buildargument is defined, but never used. Small patch to fix it, and clean up a bit of PEP8.I have also added the config option to Buildozer here: kivy/buildozer#464