Skip to content

Use KeyedBox instead of Box through transformToBoxTree() #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsbean merged 1 commit into from
Jul 27, 2019
Merged

Use KeyedBox instead of Box through transformToBoxTree() #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ struct XMLCoderElement: Equatable {
elements.append(element)
}

func transformToBoxTree() -> Box {
func transformToBoxTree() -> KeyedBox {
let attributes = KeyedStorage(self.attributes.map { attribute in
(key: attribute.key, value: StringBox(attribute.value) as SimpleBox)
})
Expand Down
2 changes: 1 addition & 1 deletion Sources/XMLCoder/Auxiliaries/XMLStackParser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class XMLStackParser: NSObject {
errorContextLength length: UInt,
shouldProcessNamespaces: Bool,
trimValueWhitespaces: Bool
) throws -> Box {
) throws -> KeyedBox {
let parser = XMLStackParser(trimValueWhitespaces: trimValueWhitespaces)

let node = try parser.parse(
Expand Down
5 changes: 1 addition & 4 deletions Tests/XMLCoderTests/Minimal/BoxTreeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@ class BoxTreeTests: XCTestCase {
attributes: []
)

guard let boxTree = root.transformToBoxTree() as? KeyedBox else {
XCTFail("boxtTree is not a KeyedBox")
return
}
let boxTree = root.transformToBoxTree()
let foo = boxTree.elements["foo"]
XCTAssertEqual(foo.count, 2)
}
Expand Down