Fixes case insensitive headers#2358
Merged
jknack merged 3 commits intojooby-project:2.xfrom Jun 6, 2021
Merged
Conversation
This is based on a TreeMap with a case insensitive order because HTTP headers should be case insensitive. Fixes issue jooby-project#2357
jknack
requested changes
May 28, 2021
| @@ -26,11 +26,11 @@ | |||
| import java.util.function.BiConsumer; | |||
|
|
|||
| public class HashValue implements ValueNode, Formdata { | |||
Member
There was a problem hiding this comment.
What if we allow hashvalue to get a Supplier<Map<String, ValueNode>> at construction level, then we add a Value.headers static method and from there we provide a TreeHashMap?
Removes previous HeadersValue after code review. Fixes issue jooby-project#2357
jknack
approved these changes
Jun 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #2357