Skip to content

Fix "permission denied" issue with gradlew and MavenW#700

Merged
eranturgeman merged 4 commits intojfrog:devfrom
eranturgeman:fix-gradlew-permission-denied-issue
Mar 19, 2026
Merged

Fix "permission denied" issue with gradlew and MavenW#700
eranturgeman merged 4 commits intojfrog:devfrom
eranturgeman:fix-gradlew-permission-denied-issue

Conversation

@eranturgeman
Copy link
Contributor

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@eranturgeman eranturgeman requested a review from attiasas March 18, 2026 11:04
@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels Mar 18, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 18, 2026
Copy link
Collaborator

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job!

Consider:

🟡 [Correctness]
mvn.go uses exec.Command("./mvnw", goals...) directly — the same pattern that caused the gradlew bug.

Apply the same sh workaround to RunMvnCmd for the wrapper path (or extract a shared helper).

@attiasas attiasas self-requested a review March 19, 2026 07:56
@eranturgeman eranturgeman changed the title Fix "permission denied" issue with gradlew Fix "permission denied" issue with gradlew and MavenW Mar 19, 2026
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 19, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 19, 2026
@github-actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@eranturgeman eranturgeman merged commit 4485dda into jfrog:dev Mar 19, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants