Conversation
| member_check: true | ||
| } | ||
| member_check: true, | ||
| }; |
There was a problem hiding this comment.
This is just a JSON literal does not need a semicolon. All you semicolon lovers 😅
There was a problem hiding this comment.
Well, normally your IDE should pick up eslint config and blame you for not following the standard.
Anyway, who cares, let's just make CI happy and green
There was a problem hiding this comment.
well my vscode did not pickup any eslint errors, did not have the extension installed 😢
There was a problem hiding this comment.
Maybe setup pre-commit hook to run "lint" script?
src/services/PushRule.js
Outdated
| } | ||
|
|
||
| return RequestHelper.put(this, `projects/${pId}/push_rule`, args); | ||
| return RequestHelper.put(this, `projects/${pId}/push_rule`); |
There was a problem hiding this comment.
This should be options as second argument since it is a put.
pablobirukov
force-pushed
the
maintain-ci
branch
from
eee7fc1 to
ad7d4b2
Compare
|
@Casz can you please take a look at the failing PushRule test? If you don't have time at the moment, I'd suggest to disable the test and proceed w/ merge, so that CI can start revealing problems in pending pulls |
|
Oh, wait a second. Did it ever work? It should not work w/o license uploaded since it's an EE feature |
|
Ehh sorry did not think of that @R00GER my bad 😭 |
|
caching can be evil 😈 |
|
Omg 👏🏽👏🏽👏🏽👏🏽🎉🎉🎉🎉🎉🎉 |
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* Disable cache on travis * Fix linter failures * Disable PushRule test (EE-only feature)
* Disable cache on travis * Fix linter failures * Disable PushRule test (EE-only feature)
3 participants
No description provided.