Skip to content

Fix paused column output on Device resource#231

Merged
felix-kaestner merged 1 commit intomainfrom
paused
Mar 16, 2026
Merged

Fix paused column output on Device resource#231
felix-kaestner merged 1 commit intomainfrom
paused

Conversation

@felix-kaestner
Copy link
Contributor

@felix-kaestner felix-kaestner commented Mar 13, 2026

Change DeviceSpec.Paused from *bool to bool with a default value of false so the field is always present in the serialized JSON. This fixes the empty Paused column when listing Devices with -o wide, as the JSONPath .spec.paused previously resolved to nothing when the optional pointer was nil.

Before

λ kubectl get device -o wide
NAME    ENDPOINT           MANUFACTURER   MODEL        SERIALNUMBER   FIRMWAREVERSION   PORTS        PAUSED   PHASE     READY   AGE
leaf1   192.168.5.2:9339   Cisco          N9K-C9300v   9D9X10CJ4NB    10.4(6)           0/64 (10g)            Running   True    2s

After

λ kubectl get device -o wide
NAME    ENDPOINT           MANUFACTURER   MODEL        SERIALNUMBER   FIRMWAREVERSION   PORTS        PAUSED   PHASE     READY   AGE
leaf1   192.168.5.2:9339   Cisco          N9K-C9300v   9D9X10CJ4NB    10.4(6)           0/64 (10g)   false    Running   True    2s

@felix-kaestner felix-kaestner requested a review from a team as a code owner March 13, 2026 13:02
@felix-kaestner felix-kaestner enabled auto-merge (rebase) March 13, 2026 13:02
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Mar 14, 2026
@hardikdr hardikdr added this to Roadmap Mar 14, 2026
Change DeviceSpec.Paused from *bool to bool with a default value of
false so the field is always present in the serialized JSON. This
fixes the empty Paused column when listing Devices with `-o wide`, as
the JSONPath `.spec.paused` previously resolved to nothing when the
optional pointer was nil.
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/annotations 100.00% (ø)
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx 63.48% (+0.52%) 👍
github.com/ironcore-dev/network-operator/internal/controller/core 63.15% (+0.08%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/device_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/annotations/annotations.go 100.00% (ø) 4 4 0
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/bordergateway_controller.go 51.91% (ø) 235 122 113
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/system_controller.go 63.48% (ø) 115 73 42
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/vpcdomain_controller.go 75.56% (+1.33%) 225 170 (+3) 55 (-3) 👍
github.com/ironcore-dev/network-operator/internal/controller/core/acl_controller.go 58.57% (ø) 140 82 58
github.com/ironcore-dev/network-operator/internal/controller/core/banner_controller.go 61.31% (+2.98%) 168 103 (+5) 65 (-5) 👍
github.com/ironcore-dev/network-operator/internal/controller/core/bgp_controller.go 58.57% (ø) 140 82 58
github.com/ironcore-dev/network-operator/internal/controller/core/bgp_peer_controller.go 64.97% (ø) 177 115 62
github.com/ironcore-dev/network-operator/internal/controller/core/certificate_controller.go 58.44% (ø) 154 90 64
github.com/ironcore-dev/network-operator/internal/controller/core/dns_controller.go 58.39% (ø) 137 80 57
github.com/ironcore-dev/network-operator/internal/controller/core/evpninstance_controller.go 67.63% (ø) 207 140 67
github.com/ironcore-dev/network-operator/internal/controller/core/interface_controller.go 75.00% (ø) 392 294 98
github.com/ironcore-dev/network-operator/internal/controller/core/isis_controller.go 60.39% (ø) 154 93 61
github.com/ironcore-dev/network-operator/internal/controller/core/lldp_controller.go 68.14% (ø) 204 139 65
github.com/ironcore-dev/network-operator/internal/controller/core/managementaccess_controller.go 58.39% (ø) 137 80 57
github.com/ironcore-dev/network-operator/internal/controller/core/ntp_controller.go 58.39% (ø) 137 80 57
github.com/ironcore-dev/network-operator/internal/controller/core/nve_controller.go 68.04% (+0.91%) 219 149 (+2) 70 (-2) 👍
github.com/ironcore-dev/network-operator/internal/controller/core/ospf_controller.go 59.02% (ø) 183 108 75
github.com/ironcore-dev/network-operator/internal/controller/core/pim_controller.go 60.39% (ø) 154 93 61
github.com/ironcore-dev/network-operator/internal/controller/core/prefixset_controller.go 62.14% (ø) 140 87 53
github.com/ironcore-dev/network-operator/internal/controller/core/routingpolicy_controller.go 65.26% (ø) 190 124 66
github.com/ironcore-dev/network-operator/internal/controller/core/snmp_controller.go 58.39% (ø) 137 80 57
github.com/ironcore-dev/network-operator/internal/controller/core/syslog_controller.go 58.57% (ø) 140 82 58
github.com/ironcore-dev/network-operator/internal/controller/core/user_controller.go 57.14% (ø) 168 96 72
github.com/ironcore-dev/network-operator/internal/controller/core/vlan_controller.go 61.33% (-2.67%) 150 92 (-4) 58 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/vrf_controller.go 61.27% (ø) 142 87 55

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/controller/core/lldp_controller_test.go

@felix-kaestner felix-kaestner merged commit a946f50 into main Mar 16, 2026
11 checks passed
@felix-kaestner felix-kaestner deleted the paused branch March 16, 2026 08:35
@github-project-automation github-project-automation bot moved this to Done in Roadmap Mar 16, 2026
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project. area/switch-automation Automation processes for network switch management and operations.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants