Skip to content

Fix query params not being used in Intercom::BaseCollectionProxy #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SeanHealy33 merged 1 commit into from
Dec 16, 2022
Merged

Fix query params not being used in Intercom::BaseCollectionProxy #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/intercom/base_collection_proxy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,7 @@ def has_next_link?(response_hash)
end

def payload
payload = {}
payload[:per_page] = @params[:per_page] if @params[:per_page]
payload[:starting_after] = @params[:starting_after] if @params[:starting_after]
payload
@params.keep_if { |k, v| !v.nil? }.to_h
end
end
end
5 changes: 5 additions & 0 deletions spec/unit/intercom/base_collection_proxy_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,9 @@
contacts.each { |contact| emails_iter2 << contact.email }
_(emails_iter1).must_equal emails_iter2
end

it "supports query params" do
client.expects(:get).with("/conversations", {:intercom_user_id => 'abcdef0000'}).returns(test_conversation_list)
_(client.conversations.find_all(:intercom_user_id => 'abcdef0000').map(&:id)).must_equal %w[147]
end
end