#find_all method does not filter by user ID after bump to 4.2.0

[diN0bot]

Please use the following template to submit your issue. Following this template will allow us to quickly investigate and help you with your issue. Please be aware that issues which do not conform to this template may be closed.

For feature requests please contact us at team@intercom.io

Version info

• intercom-ruby version: 4.2.0
• Ruby version: ruby 2.6.8p205 (2021-07-07 revision 67951) [universal.arm64e-darwin21]

Expected behavior

#find_all filters by user ID

Actual behavior

Our code creates single message threads with clients.

After deploying Intercom-ruby 4.2.0, we started seeing group chats on intercom, with clients seeing messages intended for other clients.

We reverted the version bump and this stopped.

We believe #find_all is the problem (and are planning to switch to #search instead?)

Steps to reproduce

Logs

[SeanHealy33]

Hi @diN0bot

Thank you for the bug report.

What find_all(contacts, conversations etc) are you experiencing issues on since 4.2.0 Also what Intercom API Version are you running on.

[tdooner]

Hi @SeanHealy33, I work with @diN0bot.

We were seeing the issue specifically with the conversations resource.

I believe this was caused by this commit which updates the conversation's collection_proxy_class to be the Intercom::BaseCollectionProxy rather than the Intercom::ClientCollectionProxy.

It looks like the BaseCollectionProxy doesn't use the @params passed in by FindAll when composing the URL for each page:

# lib/intercom/base_collection_proxy.rb
def payload
  payload = {}
  payload[:per_page] = @params[:per_page] if @params[:per_page]
  payload[:starting_after] = @params[:starting_after] if @params[:starting_after]
  payload
end

In that file, I don't understand exactly what's going on with @params except I think I'm seeing that any params there won't get passed in to the eventual payload in the same way they are in ClientCollectionProxy.

[tdooner]

@SeanHealy33 Here's a PR that I believe will fix the issue. This was a pretty catastrophic issue for us yesterday. Our code uses #find_all to match incoming SMS's and Emails with the Intercom conversation that they belong to. So, without these parameters, all incoming messages were getting associated with an arbitrary conversation, causing a ton of havoc.

I think this is definitely worth a point release when fixed, and potentially worth pulling 4.2.0 from rubygems.

[SeanHealy33]

Released 4.2.1 which contains your fix @tdooner thank you for the submission!

I've also taken the time to add an additional test to avoid a regression like this again.

[diN0bot]

Awesome! Thanks Sean 💯