Conversation
| )?; | ||
| writeln!( | ||
| writer, | ||
| "{}#[allow(clippy::needless_borrows_for_generic_args)]", |
There was a problem hiding this comment.
apparently the new version of clippy flags some of this code as "needless borrows" but under a different lint (needless_borrow previously and now needless_borrows_for_generic_args)
| name: Install protobuf and git | ||
| command: pacman -Sy --noconfirm protobuf git && protoc --version | ||
| name: Install protobuf and git and dependencies | ||
| command: pacman -Sy --noconfirm protobuf git gcc-libs && protoc --version |
There was a problem hiding this comment.
This is the fix for https://app.circleci.com/pipelines/github/influxdata/pbjson/274/workflows/b620d772-632d-4dd8-bc83-cd9a0e01a30b/jobs/1432
It appears the new version of protoc needs its libraries updated as well
| let Timestamp { seconds, nanos } = value; | ||
|
|
||
| let dt = NaiveDateTime::from_timestamp_opt( | ||
| Self::from_timestamp( |
There was a problem hiding this comment.
This is needed to get clippy passing https://app.circleci.com/pipelines/github/influxdata/pbjson/274/workflows/b620d772-632d-4dd8-bc83-cd9a0e01a30b/jobs/1431
Newer versions of Chrono have deprecated several APIs
| @@ -1,3 +1,3 @@ | |||
| [toolchain] | |||
| channel = "1.72" | |||
| channel = "1.74" | |||
There was a problem hiding this comment.
|
@crepererum or @jeffreyssmith2nd do you happen to have a few moments to review a PR to get CI passing again? |
|
Thanks @wiedld and @crepererum |
3 participants
Rationale
CI appears to be failing on main: https://app.circleci.com/pipelines/github/influxdata/pbjson?branch=main due to some bitrot
Changes
Let's fix those failures