styles converter transparency fix and code modernisation#93
styles converter transparency fix and code modernisation#93loebl wants to merge 6 commits intoifcquery:masterfrom
Conversation
Also changed the code to use more automatic type deduction. Transparency was wrongly taken from SufaceStyleRendering, although it is already available in SurfaceStyleShading.
|
Thanks for the pull request. However, heavy usage of the auto keyword is a different coding style, that I don't really like too much. Mostly I actually prefer the explicit datatype. You can see more clearly what it is, and jump more easily to the class definition in case you want to look at the attributes for example. It is a bit more text, but it makes it better readable. An std::vector as return value could cause some copy operations. I prefer to pass a reference as parameter. I'm aware that loops can be written like for( auto node : vec_nodes ). But I don't really use it any more because when debugging, you never know in which round you are. If you agree, I would like to keep the pull request open and take some parts of it in the future. |
|
sure, no problem |
This pull request contains the following changes:
If you only want the fix separately, I can put it in an isolated pull request.