Fix guest tracing filter #977
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblnz
added
the
kind/enhancement
dblnz
force-pushed
the
fix-tracing-filter
branch
from
489acde to
7ff7b03
Compare
…arent Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
dblnz
force-pushed
the
fix-tracing-filter
branch
from
7ff7b03 to
58caf0d
Compare
dblnz
requested review from
danbugs,
devigned,
jprendes,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
ludfjig
approved these changes
Jan 23, 2026
Comment on lines
+40
to
+48
| fn convert_level_filter(filter: tracing::log::LevelFilter) -> tracing_core::LevelFilter { | ||
| match filter { | ||
| tracing::log::LevelFilter::Off => tracing_core::LevelFilter::OFF, | ||
| tracing::log::LevelFilter::Error => tracing_core::LevelFilter::ERROR, | ||
| tracing::log::LevelFilter::Warn => tracing_core::LevelFilter::WARN, | ||
| tracing::log::LevelFilter::Info => tracing_core::LevelFilter::INFO, | ||
| tracing::log::LevelFilter::Debug => tracing_core::LevelFilter::DEBUG, | ||
| tracing::log::LevelFilter::Trace => tracing_core::LevelFilter::TRACE, | ||
| } |
Contributor
There was a problem hiding this comment.
Is it possible to tracing_core::LevelFilter everywhere instead of having this? (in entrypoint of hyperlight_guest_bin + whatever the host passes to the guest)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #990.
Currently, when tracing guests, the max log level parameter provided to the guest is not used to filter out traces.
This PR adds the filtering capability for the guest tracing and also modifies some of the trace levels in the guest.
For that to work, a change in the
integration_tests.rswas necessary to update the number of expected logs inlog_messagetest