Fix the pinning of Rubocop version#716
Merged
tarcieri merged 5 commits intohttprb:mainfrom Jun 16, 2022
drwl:drwl/fix-rubocop-issues
Merged
Fix the pinning of Rubocop version#716tarcieri merged 5 commits intohttprb:mainfrom drwl:drwl/fix-rubocop-issues
tarcieri merged 5 commits intohttprb:mainfrom
drwl:drwl/fix-rubocop-issues
Conversation
Contributor
Author
|
It's not clear why the lint step is failing: https://github.com/httprb/http/runs/6890611978?check_suite_focus=true Locally this passes for me |
rubocop --auto-gen-config
Contributor
Author
|
@tarcieri I'm not able to request reviewers, but this should fix the failed linting step in various PRs. |
Contributor
Author
|
cc @ixti |
Member
|
Thanks! |
Member
|
LOL I guess I'm too late for the review :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins Rubocop to the last version that's supported by Ruby 2.5. I think it was improperly pinned/Rubocop's versioning went different than expected.
gem "rubocop", "~> 1.21"allows for any versions < 2.Some PRs are experiencing unrelated linting issues. I don't have the context to safely make these changes, but this change should unblock folks.