This repository was archived by the owner on Oct 17, 2023. It is now read-only.
feat(hsclient): add signing_options param to sig request methods#54
Closed
souldeux wants to merge 1 commit intohellosign:v3from
Closed
feat(hsclient): add signing_options param to sig request methods#54souldeux wants to merge 1 commit intohellosign:v3from
souldeux wants to merge 1 commit intohellosign:v3from
Conversation
|
@hellosign so you abandon your own client library? 1 year no update and you ignore nice pull requests? Are you asking your clients to just not use your product? |
Contributor
|
This has been included as part of merge #51 which includes signing options and can be cancelled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of HSClient does not provide a way to interact with the
signing_optionsparameter noted in this spot (among others) in the documentation: https://app.hellosign.com/api/reference#send_signature_request. This PR updates the_send_signature_requestand_send_signature_request_with_templatemethods to respect asigning_optionsparameter, and updates the methods that call those internal methods to accept and pass along asigning_optionsparameter as well.