Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Comments

Use exception constructor that takes httpCode in asHttpCode method#79

Closed
gwongz wants to merge 1 commit intohellosign:masterfrom
gwongz:add-code-to-exception
Closed

Use exception constructor that takes httpCode in asHttpCode method#79
gwongz wants to merge 1 commit intohellosign:masterfrom
gwongz:add-code-to-exception

Conversation

@gwongz
Copy link

@gwongz gwongz commented Jun 8, 2018

No description provided.

@jspaetzel
Copy link
Member

jspaetzel commented Jul 19, 2018

Thanks for the contribution @gwongz

How about adding a constructor to HelloSignException for this while we're at it? I'd rather avoid passing null values.

public HelloSignException(String message, Integer httpCode) { this(message, httpCode, null, null); }

Then it can just be throw new HelloSignException("HTTP Code " + code, code); in asHttpCode

@jyoung488
Copy link

@jspaetzel looks good to me!

@jspaetzel jspaetzel closed this Aug 11, 2018
@jspaetzel
Copy link
Member

Thanks for the contribution, im going to followup on this in #82

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants