This repository was archived by the owner on Oct 17, 2023. It is now read-only.
Use exception constructor that takes httpCode in asHttpCode method#79
Closed
gwongz wants to merge 1 commit intohellosign:masterfrom
Closed
Use exception constructor that takes httpCode in asHttpCode method#79gwongz wants to merge 1 commit intohellosign:masterfrom
gwongz wants to merge 1 commit intohellosign:masterfrom
Conversation
3af41cd to
a9305ba
Compare
Member
|
Thanks for the contribution @gwongz How about adding a constructor to HelloSignException for this while we're at it? I'd rather avoid passing null values.
Then it can just be |
|
@jspaetzel looks good to me! |
Member
|
Thanks for the contribution, im going to followup on this in #82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.