This repository was archived by the owner on Oct 17, 2023. It is now read-only.
Use enums with explicit values and add missing FieldType enums#103
Merged
Use enums with explicit values and add missing FieldType enums#103
Conversation
jspaetzel
changed the title
jspaetzel
changed the title
jspaetzel
changed the title
jspaetzel
commented
Feb 28, 2020
Comment on lines
+153
to
+165
| List<FieldType> mergeableFieldTypes = Arrays.asList( | ||
| FieldType.CHECKBOX, | ||
| FieldType.TEXT | ||
| ); | ||
|
|
||
| if (!mergeableFieldTypes.contains(type)) { | ||
| List<String> asStrings = mergeableFieldTypes | ||
| .stream() | ||
| .map(Enum::toString) | ||
| .collect(Collectors.toList()); | ||
| throw new HelloSignException( | ||
| "Only 'text' or 'checkbox' types allowed for merge fields."); | ||
| String.format("Only %s types allowed for merge fields.", String.join(",", asStrings)) | ||
| ); |
Member
Author
There was a problem hiding this comment.
This change was unnecessary since we're not actually adding any other types. I might revert this part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed how this is done mainly because
TEXT_MERGE("text-merge");and others with dashes can't be defined as an enum liketext-merge.