Add typing annotations for functions in can.bus#652
Merged
hardbyte merged 7 commits intohardbyte:developfrom Jul 29, 2019
Merged
Add typing annotations for functions in can.bus#652hardbyte merged 7 commits intohardbyte:developfrom
hardbyte merged 7 commits intohardbyte:developfrom
Conversation
Collaborator
Author
|
I wasn't sure how to handle annotating Adding annotations to As such, I've skipped it for now, but any ideas or insights would be appreciated! |
This adds typing annotations for use via mypy for all functions under can.bus. This works towards PEP 561 compatibility.
38e18df to
e03464b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #652 +/- ##
==========================================
+ Coverage 67.67% 67.7% +0.03%
==========================================
Files 68 68
Lines 6098 6104 +6
==========================================
+ Hits 4127 4133 +6
Misses 1971 1971 |
Codecov Report
@@ Coverage Diff @@
## develop #652 +/- ##
===========================================
+ Coverage 67.67% 67.73% +0.05%
===========================================
Files 68 69 +1
Lines 6098 6109 +11
===========================================
+ Hits 4127 4138 +11
Misses 1971 1971 |
hardbyte
requested changes
Jul 23, 2019
Owner
Add a Type Alias for CAN Filters used by can.bus
4a6efd2 to
f167be6
Compare
Remove unused Dict from can.bus imports
karlding
commented
Jul 23, 2019
hardbyte
reviewed
Jul 23, 2019
hardbyte
reviewed
Jul 23, 2019
With the introduction of the sphinx-autodoc-typehints extension, we don't need to duplicate typing information in the docstring as well as the function signature.
Collaborator
felixdivo
approved these changes
Jul 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds typing annotations for use via mypy for all functions under
can.bus.
This works towards PEP 561 compatibility.