graph, graphql, store: Coerce Int8 values to ints#5034
Closed
Conversation
Previously, they were coerced to strings which ultimately leads to errors when lists of int8 are used in queries
Contributor
|
@lutter I think the max value of |
|
This pull request hasn't had any activity for the last 90 days. If there's no more activity over the course of the next 14 days, it will automatically be closed. |
Collaborator
Author
|
Closing this since it's not been active for a while. Feel free to reopen when you're ready to work on this again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, they were coerced to strings which ultimately leads to errors when lists of int8 are used in queries
@dotansimha Do you remember why
Int8was initially coerced intoStringin a lot of places? The whole topic of coercion is really confusing to me; part of it is because theValueofgraphql-parsercan't represent all the values we deal with internally (like bytes or int4 vs int8) and so you are forever trying to figure out if a string is really a string or whether it's a byte array. The other part is that coercion happens all over the place and it's really hard to draw a line between 'here we are dealing with values that have fairly random types and aren't checked yet' vs 'these values have been properly checked and express the proper type'. I wonder if we should expand ther::Valuetype to faithfully represent all value types, and take the conversion fromq::Valuetor::Valueas the point where we go from unchecked to checked.