feat: Add SuperObjectValue and unit test#145
Closed
summer-ji-eng wants to merge 9 commits intomasterfrom
Closed
Conversation
summer-ji-eng
changed the title
* feat: support templated method definitions * fix!: MethodInvocationExpr: use TypeNode instead of names for static references * feat: mix IdNode and TypeNode in template vars for methods * feat: generate GrpcServiceCallableFactory class * fix: clean up composer methods * feat: add starter for ServiceClientTest generation
miraleung
suggested changes
Jul 30, 2020
| } | ||
|
|
||
| @Test | ||
| public void invalidSuperObjectValue_NonReferenceType() { |
Contributor
There was a problem hiding this comment.
_nonReferenceType, same below.
miraleung
approved these changes
Jul 31, 2020
miraleung
suggested changes
Jul 31, 2020
Contributor
miraleung
left a comment
miraleung
left a comment
There was a problem hiding this comment.
One more change needed: Can we add an ImportWriterVisitor test? super may be in a different package than the current class.
Contributor
xiaozhenliu-gg5
left a comment
xiaozhenliu-gg5
left a comment
There was a problem hiding this comment.
Seems the composer changes (ServiceClientTestClassComposer) are already checked in? If that is not intended in this PR can we checkout/merge master to isolate the superObjectValue change? Thanks
Contributor
Author
|
Fix merge problem and sent new PR#159 |
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
* updated versions.txt [ci skip] * updated google-cloud-core-bom/pom.xml [ci skip] * updated google-cloud-core-grpc/pom.xml [ci skip] * updated google-cloud-core-http/pom.xml [ci skip] * updated google-cloud-core/pom.xml [ci skip] * updated pom.xml [ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fullfill super