Add validation of generation and metageneration to upload functions#98
Add validation of generation and metageneration to upload functions#98HollayHorvath wants to merge 2 commits intogoogleapis:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
frankyn
left a comment
There was a problem hiding this comment.
I have one nit, but overall LGTM, thanks for picking this up @HollayHorvath!
| size, | ||
| num_retries, | ||
| predefined_acl, | ||
| generation_match, |
There was a problem hiding this comment.
Could you update the name with expected prefix of if_ to follow the API spec?
| content_type = u"font/woff" | ||
| client = mock.sentinel.client | ||
| predefined_acl = kwargs.get("predefined_acl", None) | ||
| generation_match = kwargs.get("generation_match", None) |
There was a problem hiding this comment.
One more request, could you add system tests that exercise these new parameters?
|
Thanks for your support @HollayHorvath, you helped get this ball moving and will have it out in the library soon. @IlyaFaer is taking the work you've done and making necessary changes to get into the library. I'm closing out this PR and continuing the remaining discussions in #111. |
Fixes #16 🦕