feat: add preconditions and retry configuration to blob.create_resumable_upload_session#484
Merged
feat: add preconditions and retry configuration to blob.create_resumable_upload_session#484
Conversation
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
cojenco
changed the title
tritone
reviewed
Jun 30, 2021
Contributor
tritone
left a comment
tritone
left a comment
There was a problem hiding this comment.
Generally looks good. Did you test against the emulator that things are working?
| def test_create_resumable_upload_session_with_conditional_retry_failure(self): | ||
| self._create_resumable_upload_session_helper( | ||
| retry=DEFAULT_RETRY_IF_GENERATION_SPECIFIED | ||
| ) |
Contributor
There was a problem hiding this comment.
How does this test verify that retries don't happen?
Contributor
Author
There was a problem hiding this comment.
@tritone, I've tested the retry behaviors against the emulator that things are working as intended. The unit test asserts if the mock call was made with the corresponding url and query params.
tritone
approved these changes
Jun 30, 2021
cojenco
added a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…ble_upload_session (googleapis#484) * feat: add preconditions and retry configuration to blob.create_resumable_upload_session * move imports
cojenco
added a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…ble_upload_session (googleapis#484) * feat: add preconditions and retry configuration to blob.create_resumable_upload_session * move imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds preconditions and retry configuration to the upload entry method
blob.create_resumable_upload_session(), in the continuation of #447 and #480.This exposes the method to preconditions and therefore can make the operation conditional. It can also be configured with Retry objects and ConditionalRetryPolicy objects.