feat: added retry and timeout params to partition read in database and snapshot class#278
Merged
larkee merged 7 commits intogoogleapis:masterfrom Mar 24, 2021
vi3k6i5:partitioned_read_retry_timeout
Merged
feat: added retry and timeout params to partition read in database and snapshot class#278larkee merged 7 commits intogoogleapis:masterfrom vi3k6i5:partitioned_read_retry_timeout
larkee merged 7 commits intogoogleapis:masterfrom
vi3k6i5:partitioned_read_retry_timeout
Conversation
Merging from original repo to update fork.
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
larkee
reviewed
Mar 17, 2021
Contributor
larkee
left a comment
larkee
left a comment
There was a problem hiding this comment.
LGTM so far 👍
generate_read_batches and generate_query_batches both generate partitions which are then used with process_read_batch and process_query_batch respectively. Please also add the options to these methods to complete the support
Contributor
Author
|
@larkee : made the change. |
larkee
reviewed
Mar 22, 2021
Contributor
larkee
left a comment
larkee
left a comment
There was a problem hiding this comment.
LGTM other than some minor test nits
…ython-spanner into partitioned_read_retry_timeout
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 25, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [3.3.0](https://github.com/googleapis/python-spanner/compare/v3.2.0...v3.3.0) (2021-03-25) ### Features * add encryption_info to Database ([#284](https://github.com/googleapis/python-spanner/issues/284)) ([2fd0352](https://github.com/googleapis/python-spanner/commit/2fd0352f695d7ab85e57d8c4388f42f91cf39435)) * add support for CMEK ([#105](https://github.com/googleapis/python-spanner/issues/105)) ([e990ff7](https://github.com/googleapis/python-spanner/commit/e990ff70342e7c2e27059e82c8d74cce39eb85d0)) * add support for custom timeout and retry parameters in execute_update method in transactions ([#251](https://github.com/googleapis/python-spanner/issues/251)) ([8abaebd](https://github.com/googleapis/python-spanner/commit/8abaebd9edac198596e7bd51d068d50147d0391d)) * added retry and timeout params to partition read in database and snapshot class ([#278](https://github.com/googleapis/python-spanner/issues/278)) ([1a7c9d2](https://github.com/googleapis/python-spanner/commit/1a7c9d296c23dfa7be7b07ea511a4a8fc2c0693f)) * **db_api:** support executing several DDLs separated by semicolon ([#277](https://github.com/googleapis/python-spanner/issues/277)) ([801ddc8](https://github.com/googleapis/python-spanner/commit/801ddc87434ff9e3c86b1281ebfeac26195c06e8)) ### Bug Fixes * avoid consuming pending null values when merging ([#286](https://github.com/googleapis/python-spanner/issues/286)) ([c6cba9f](https://github.com/googleapis/python-spanner/commit/c6cba9fbe4c717f1f8e2a97e3f76bfe6b956e55b)) * **db_api:** allow file path for credentials ([#221](https://github.com/googleapis/python-spanner/issues/221)) ([1de0284](https://github.com/googleapis/python-spanner/commit/1de028430b779a50d38242fe70567e92b560df5a)) * **db_api:** ensure DDL statements are being executed ([#290](https://github.com/googleapis/python-spanner/issues/290)) ([baa02ee](https://github.com/googleapis/python-spanner/commit/baa02ee1a352f7c509a3e169927cf220913e521f)) * **db_api:** revert Mutations API usage ([#285](https://github.com/googleapis/python-spanner/issues/285)) ([e5d4901](https://github.com/googleapis/python-spanner/commit/e5d4901e9b7111b39dfec4c56032875dc7c6e74c)) ### Documentation * fix docstring types and typos ([#259](https://github.com/googleapis/python-spanner/issues/259)) ([1b0ce1d](https://github.com/googleapis/python-spanner/commit/1b0ce1d2986085ce4033cf773eb6c5d3b904473c)) * fix snapshot usage ([#291](https://github.com/googleapis/python-spanner/issues/291)) ([eee2181](https://github.com/googleapis/python-spanner/commit/eee218164c3177586b73278aa21495280984af89)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added retry and timeout params to partition read in database and snapshot class
Fixes #71 🦕