Open
Conversation
…un outside of the UTC timezone
product-auto-label
bot
added
size: s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
test_batch_insert_then_read_all_datatypesandtest_execute_sql_w_timestamp_bindingstests fail when run outside of the UTC timezone. This is frustrating when running tests locally for those who are based in a different timezone.This PR moves the handling of the timezones to
_assert_timestamp. All datetime objects created without a timezone are assumed to be in local time. By asserting that it does not have a timezone first, we can safely convert it to UTC which should match the value returned from Spanner.