chore: add docfx session to noxfile, normalize#100
Merged
gcf-merge-on-green[bot] merged 2 commits intomasterfrom Aug 5, 2020
Merged
chore: add docfx session to noxfile, normalize#100gcf-merge-on-green[bot] merged 2 commits intomasterfrom
gcf-merge-on-green[bot] merged 2 commits intomasterfrom
Conversation
google-cla
bot
added
the
cla: yes
Contributor
|
@tseaver Thanks, I think we should also run synthtool to have other changes, in order to see if the test is actually passing. |
Contributor
Author
|
@tmatsuo I lost my synthtool-fu during my hiatus. Can I just get my local copy updated to current |
Contributor
|
@tseaver Maybe I can add a commit to the branch. For the record, I was told there is a dependency on bazel. |
Contributor
|
I think you rebased, that should work too. Thanks! |
Contributor
Author
Contributor
|
The docs-presubmit is passing :) Do you know why the samples are failing? |
Contributor
|
At a glance, the test has sth like |
Contributor
Author
|
@tmatsuo We are hitting quota issues, breaking snippets / systests / samples. |
tmatsuo
approved these changes
Aug 5, 2020
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
added
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreaking the
docs-presubmitbuild.