Skip to content

feat: add always_use_jwt_access#714

Merged
gcf-merge-on-green[bot] merged 2 commits intomasterfrom
owl-bot-9905973e-8379-4288-8fa6-ea358d9341c1
Jun 23, 2021
Merged

feat: add always_use_jwt_access#714
gcf-merge-on-green[bot] merged 2 commits intomasterfrom
owl-bot-9905973e-8379-4288-8fa6-ea358d9341c1

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jun 22, 2021

... chore: update gapic-generator-ruby to the latest commit chore: release gapic-generator-typescript 1.5.0

Committer: @miraleung
PiperOrigin-RevId: 380641501

Source-Link: googleapis/googleapis@076f7e9

Source-Link: https://github.com/googleapis/googleapis-gen/commit/27e4c88b4048e5f56508d4e1aa417d60a3380892

@gcf-owl-bot
chore: remove all monolith Bazel deps chore: release gapic-generator-…
4c95591 
…csharp v1.3.7 chore: release gapic-generator-go 0.20.5 chore: release gapic-generator-java 1.0.14 chore: release gapic-generator-php 1.0.1 chore: release gapic-generator-python 0.50.0 chore: update gapic-generator-ruby to the latest commit chore: release gapic-generator-typescript 1.5.0

Committer: @miraleung
PiperOrigin-RevId: 380641501

Source-Link: googleapis/googleapis@076f7e9

Source-Link: googleapis/googleapis-gen@27e4c88
@gcf-owl-bot gcf-owl-bot bot requested a review from a team June 22, 2021 00:31
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 22, 2021 00:31
@gcf-owl-bot gcf-owl-bot bot requested review from shollyman and removed request for a team June 22, 2021 00:31
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jun 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2021
@busunkim96 busunkim96 changed the title chore: remove all monolith Bazel deps chore: release gapic-generator-csharp v1.3.7 chore: release gapic-generator-go 0.20.5 chore: release gapic-generator-java 1.0.14 chore: release gapic-generator-php 1.0.1 chore: release gapic-generator-python 0.50.0... feat: add always_use_jwt_access Jun 23, 2021
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 92fbd4a into master Jun 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-9905973e-8379-4288-8fa6-ea358d9341c1 branch June 23, 2021 20:24
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 23, 2021
@plamut
Copy link
Contributor

plamut commented Jun 24, 2021

@busunkim96 Am I missing something? This PR just removes a coverage threshold line from the config, but I don't see anything JWT-related as the title suggests?

@busunkim96
Copy link
Contributor

busunkim96 commented Jun 24, 2021

@plamut Apologies, I used this tool to pick up on all PRs with the same name and rename them. 😬 I will be more careful about spot checking clients with manual layers in the future.

@tseaver
Copy link
Contributor

tseaver commented Jun 24, 2021 •
edited
Loading

@plamut, @busunkim96 Who is making a choice to drop coverage below 100%? That shoiuld never have been done by automation.

Update: Neither of the Source-Link commits seems to touch .coveragerc. That change was in fact introduced in googleapis/gapic-generator-python#774. @busunkim96 wrote there:

This change is written so that the library is (temporarily) compatible with older google-api-core and google-auth versions.
Because of this it not possible to reach 100% coverage on a single unit test run. pytest runs twice in two of the nox sessions.

@plamut plamut mentioned this pull request Jun 25, 2021
Closed
tseaver added a commit that referenced this pull request Jun 25, 2021
@tseaver
Revert "feat: add always_use_jwt_access (#714)"
6e38abd 
This reverts commit 92fbd4a.
@tseaver tseaver mentioned this pull request Jun 25, 2021
Merged
tseaver added a commit that referenced this pull request Jun 25, 2021
@tseaver
Revert "feat: add always_use_jwt_access (#714)" (#722)
36b6a85 
This reverts commit 92fbd4a.
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 14, 2021
@release-please
chore: release 2.21.0 (#760)
5437d44 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.21.0](https://github.com/googleapis/python-bigquery/compare/v2.20.0...v2.21.0) (2021-07-14)


### Features

* add always_use_jwt_access ([#714](https://github.com/googleapis/python-bigquery/issues/714)) ([92fbd4a](https://github.com/googleapis/python-bigquery/commit/92fbd4ade37e0be49dc278080ef73c83eafeea18))
* add max_results parameter to some of the QueryJob methods ([#698](https://github.com/googleapis/python-bigquery/issues/698)) ([2a9618f](https://github.com/googleapis/python-bigquery/commit/2a9618f4daaa4a014161e1a2f7376844eec9e8da))
* add support for decimal target types ([#735](https://github.com/googleapis/python-bigquery/issues/735)) ([7d2d3e9](https://github.com/googleapis/python-bigquery/commit/7d2d3e906a9eb161911a198fb925ad79de5df934))
* add support for table snapshots ([#740](https://github.com/googleapis/python-bigquery/issues/740)) ([ba86b2a](https://github.com/googleapis/python-bigquery/commit/ba86b2a6300ae5a9f3c803beeb42bda4c522e34c))
* enable unsetting policy tags on schema fields ([#703](https://github.com/googleapis/python-bigquery/issues/703)) ([18bb443](https://github.com/googleapis/python-bigquery/commit/18bb443c7acd0a75dcb57d9aebe38b2d734ff8c7))
* make it easier to disable best-effort deduplication with streaming inserts ([#734](https://github.com/googleapis/python-bigquery/issues/734)) ([1246da8](https://github.com/googleapis/python-bigquery/commit/1246da86b78b03ca1aa2c45ec71649e294cfb2f1))
* Support passing struct data to the DB API ([#718](https://github.com/googleapis/python-bigquery/issues/718)) ([38b3ef9](https://github.com/googleapis/python-bigquery/commit/38b3ef96c3dedc139b84f0ff06885141ae7ce78c))


### Bug Fixes

* inserting non-finite floats with insert_rows() ([#728](https://github.com/googleapis/python-bigquery/issues/728)) ([d047419](https://github.com/googleapis/python-bigquery/commit/d047419879e807e123296da2eee89a5253050166))
* use pandas function to check for NaN ([#750](https://github.com/googleapis/python-bigquery/issues/750)) ([67bc5fb](https://github.com/googleapis/python-bigquery/commit/67bc5fbd306be7cdffd216f3791d4024acfa95b3))


### Documentation

* add docs for all enums in module ([#745](https://github.com/googleapis/python-bigquery/issues/745)) ([145944f](https://github.com/googleapis/python-bigquery/commit/145944f24fedc4d739687399a8309f9d51d43dfd))
* omit mention of Python 2.7 in `CONTRIBUTING.rst` ([#706](https://github.com/googleapis/python-bigquery/issues/706)) ([27d6839](https://github.com/googleapis/python-bigquery/commit/27d6839ee8a40909e4199cfa0da8b6b64705b2e9))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@tseaver tseaver mentioned this pull request Jul 16, 2021
Merged
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman Awaiting requested review from shollyman

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. owl-bot-copy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@plamut @busunkim96 @tseaver @yoshi-kokoro