chore: refactor cell data parsing to use classes for easier overrides#2144
Merged
chore: refactor cell data parsing to use classes for easier overrides#2144
Conversation
product-auto-label
bot
added
size: xl
tswast
requested review from
Linchin and
chalmerlowe
and removed request for
mrfaizal
6 tasks
GarrettWu
approved these changes
Mar 12, 2025
chalmerlowe
reviewed
Mar 18, 2025
chalmerlowe
reviewed
Mar 19, 2025
chalmerlowe
approved these changes
Mar 19, 2025
chalmerlowe
pushed a commit
that referenced
this pull request
Mar 25, 2025
…#2144) * chore: refactor cell data parsing to use classes for easier overrides * improve error messages with urls for valueerrors * Update tests/unit/_helpers/test_cell_data_parser.py * remove unreachable code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #1876
🦕