fix: raise error if inserting rows with unknown fields#163
fix: raise error if inserting rows with unknown fields#163tseaver merged 7 commits intogoogleapis:masterfrom
Conversation
shollyman
left a comment
There was a problem hiding this comment.
I think I'm missing something here. The user controls whether they want this behavior in tabledata.insertall via ignoreUnknownValues, which is present in the insert_rows_json() method signature, but I don't see how that's plumbed to this helper.
|
@shollyman Hmm, good point. I'll check how the helper can support the |
|
Changed the helper to include missing fields and let the backend handle that. The |
|
Just the coverage failure it seems, will cover the missed code path. |
|
Assuming that the Python3 test failures in |
|
Indeed, and those tests were updated in https://github.com/googleapis/python-bigquery/pull/192/files |
Fixes #151.
This PR makes sure that unknown fields are not silently ignored when inserting rows, but instead such errors are detected and raised loudly.
PR checklist