fix: Select expressions no-longer force use of labels#129
Merged
Conversation
added 3 commits
April 20, 2021 13:04
The source of the dependency bug is in old versions of google-cloud-core that depend on too-old versions of google-api-core.
So we don't have t mock at the api level.
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
jimfulton
changed the title
tswast
approved these changes
Apr 20, 2021
Collaborator
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Thanks for adding unit tests!
Interesting to use SQLite for unit testing, but I can roll with that.
Long-term we might want to do something with Zeta SQL (name of the BigQuery/Spanner open source implementation), but I think it's a long ways away before we get something usable like a local emulator out of that project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #78 🦕