feat: decode uri path components correctly#913
Conversation
The old implementation was incorrecly treating '+' as a space. Now the only things that get decoded in the path are uri escaped sequences. Fixes googleapis#398
googlebot
added
the
cla: yes
google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java
Show resolved
Hide resolved
google-http-client/src/main/java/com/google/api/client/util/escape/CharEscapers.java
Outdated
Show resolved
Hide resolved
google-http-client/src/main/java/com/google/api/client/util/escape/CharEscapers.java
Outdated
Show resolved
Hide resolved
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
I could swear this is reinventing something that exists in Guava, but perhaps that's only in the internal version.
|
This change caused the problem with using space in object names in java cloud storage: googleapis/java-storage#53 |
|
@dmitry-fa correct, one more issue related to this changes. |
|
Hi, in https://issuetracker.google.com/issues/217399871 we have noticed a problem with Google Sheets API when using It is a bit confusing as the error message we get shows that the problem is that the sheet title is passed in the URL and the plus gets replaced by a space, while the value range in the body remains unchanged and this mismatch results in API failures that prevent adding cells to such sheets. |
…-plugin to v3.4.0 (googleapis#913) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) ([source](https://github.com/apache/maven-javadoc-plugin)) | `3.3.2` -> `3.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
](https://renovatebot.com){kind=link}
7 participants
The old implementation was incorrectly treating '+' as a space. Now
the only things that get decoded in the path are uri escaped sequences.
Fixes #398