fix: UriTemplate reserved expansion does not escape reserved chars#1844
fix: UriTemplate reserved expansion does not escape reserved chars#1844gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Memo:
|
|
@cHengstler Can you fix the lint failure? |
|
Hi @suztomo, thanks for reviewing, linting issues should be solved now. |
| assertEquals( | ||
| "Reserved expansion must not escape chars from unreserved set according to rfc6570#section-3.2.3", | ||
| unReservedSet, | ||
| UriTemplate.expand("{+var}", requestMap, false)); |
There was a problem hiding this comment.
Memo: Python's uritemplate agrees:
>>> a="-._~"; a == URITemplate("{+var}").expand(var=a)
True
>>> a=":/?#[]@!$&'()*+,;="; a == URITemplate("{+var}").expand(var=a)
True
|
ci / lint passed. |
When using UriTemplate.expand with a reserved expansion "{+var}", a set of allowed characters must not be encoded. According to section of 3.2.3 Reserved Expansion: {+var}, unreserved and reserved character should not be escaped.
This fix adds the missing characters
#[]that must not be percent encoded when using reserved expansion.Fixes #1838