refactor(bigquery): update code samples to use strings for table and dataset IDs#9974
Merged
tswast merged 16 commits intogoogleapis:masterfrom Dec 26, 2019
Merged
refactor(bigquery): update code samples to use strings for table and dataset IDs#9974tswast merged 16 commits intogoogleapis:masterfrom
tswast merged 16 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
tswast
reviewed
Dec 23, 2019
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
LGTM once a few nits have been addressed.
| # [START bigquery_query_partitioned_table] | ||
| from google.cloud import bigquery | ||
|
|
||
| import datetime |
Contributor
There was a problem hiding this comment.
Nit: Import built-in datetime before "third-party" libraries like google-cloud-bigquery.
| # TODO(developer): Construct a BigQuery client object. | ||
| # client = bigquery.Client() | ||
|
|
||
| import datetime |
Contributor
There was a problem hiding this comment.
Nit: Import built-ins in a group before google-cloud-bigquery.
| # client = bigquery.Client() | ||
|
|
||
| import datetime | ||
| import pytz |
Contributor
There was a problem hiding this comment.
Nit: Import pytz in same import group as google-cloud-bigquery.
bigquery/samples/query_no_cache.py
Outdated
| FROM `bigquery-public-data.samples.shakespeare` | ||
| GROUP BY corpus; | ||
| """ | ||
| query_job = client.query(sql, job_config=job_config,) # Make an API request. |
Contributor
There was a problem hiding this comment.
Nit: The linter might complain about the trailing comma here.
tswast
approved these changes
Dec 26, 2019
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #8989
Closes #9596
List of changes:
New samples:
Update existing samples: