refactor(storage): deprecate Bucket.create() and requester_pays#9893
refactor(storage): deprecate Bucket.create() and requester_pays#9893IlyaFaer wants to merge 8 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
IlyaFaer
changed the title
| expected_cw = [((), expected_called_kwargs)] | ||
| self.assertEqual(_FakeConnection._called_with, expected_cw) | ||
|
|
||
| def test_create_w_user_project(self): |
There was a problem hiding this comment.
Most part of these tests had already been moved into client_test.py in this PR. Some will be moved with the current one
| http = _make_requests_session([_make_json_response(data)]) | ||
| client._http_internal = http | ||
|
|
||
| bucket = client.create_bucket(bucket_name, requester_pays=True) |
| project=project, | ||
| location=location, | ||
| predefined_acl=predefined_acl, | ||
| predefined_default_object_acl=predefined_default_object_acl, |
There was a problem hiding this comment.
Deleting old implementation and mirroring to Client.create_bucket()
…google-cloud-python into deprecate_create_bucket
|
Are there any code samples (here or in https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/storage) that still use these methods? If so, we should wait to deprecate until those are updated. Also, we should make sure every API request you can make on Bucket can also be done from Client. It'll make for a much clearer developer story when Bucket can be treated as a dumb resource object. |
|
@tswast, yeah, I've checked python-docs-samples and didn't find any mentions of
Well, I'm following the design doc for now, pushing piece by piece, as it's a lot of changes. If we need to mirror calls from |
In my opinion, piece-by-piece as you're currently doing will make it easiest for others to contribute / onboard new teammembers. |
|
Friendly ping. This PR is waiting for review |
|
Please reopen in the new repo, thanks! |
|
Moved to googleapis/python-storage#49 |
4 participants
Towards #7762
Completing steps 1, 2 and 3 from the design doc: