feat(storage): add opt-in raw download support#9572
Merged
tseaver merged 11 commits intogoogleapis:masterfrom Nov 5, 2019
tseaver:9565-storage-add-opt-in-raw-download-support
Merged
feat(storage): add opt-in raw download support#9572tseaver merged 11 commits intogoogleapis:masterfrom tseaver:9565-storage-add-opt-in-raw-download-support
tseaver merged 11 commits intogoogleapis:masterfrom
tseaver:9565-storage-add-opt-in-raw-download-support
Conversation
Avoid depending on implementation details of download objects from google-resumable-media.
Avoid depending on implementation details of download objects from google-resumable-media.
Never import module-under-test at module scope of testcase.
Avoid reusing fixtures which do more than needed.
Consolidate duplicated code in prep for adding 'raw_download' option.
If True, uses the 'RawDownload' / 'RawChunkedDownload' helpers from 'google.resumable_media', ensuring that the contents are not expanded by the requests transport.
If True, uses the 'RawDownload' / 'RawChunkedDownload' helpers from 'google.resumable_media', ensuring that the contents are not expanded by the requests transport.
googlebot
added
the
cla: yes
tseaver
changed the title
frankyn
suggested changes
Nov 1, 2019
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
Will review and marking as requested changes to prevent merges.
Thank you for your patience.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note to reviewers: this is likely better viewed commit-by-commit.
Bumps
google-resumable-mediadependency forgoogle-cloud-storageto require >= 0.5.0, whilegoogle-cloud-bigqueryjust allows it (BigQuery doesn't use the download classes).Closes #9565.