Skip to content

BigQuery: harden 'ArrayQueryParameter.from_api_repr' against missing 'parameterValue'. #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 1 commit into from
Feb 12, 2019
Merged

BigQuery: harden 'ArrayQueryParameter.from_api_repr' against missing 'parameterValue'. #7311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bigquery/google/cloud/bigquery/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,9 @@ def _from_api_repr_struct(cls, resource):
def _from_api_repr_scalar(cls, resource):
name = resource.get("name")
array_type = resource["parameterType"]["arrayType"]["type"]
values = [value["value"] for value in resource["parameterValue"]["arrayValues"]]
parameter_value = resource.get("parameterValue", {})
array_values = parameter_value.get("arrayValues", ())
values = [value["value"] for value in array_values]
converted = [
_QUERY_PARAMS_FROM_JSON[array_type](value, None) for value in values
]
Expand Down
12 changes: 12 additions & 0 deletions bigquery/tests/unit/test_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,18 @@ def test_from_api_repr_wo_name(self):
self.assertEqual(param.array_type, "INT64")
self.assertEqual(param.values, [1, 2])

def test_from_api_repr_wo_values(self):
# Back-end may not send back values for empty array params. See #7309
RESOURCE = {
"name": "foo",
"parameterType": {"type": "ARRAY", "arrayType": {"type": "INT64"}},
}
klass = self._get_target_class()
param = klass.from_api_repr(RESOURCE)
self.assertEqual(param.name, "foo")
self.assertEqual(param.array_type, "INT64")
self.assertEqual(param.values, [])

def test_from_api_repr_w_struct_type(self):
from google.cloud.bigquery.query import StructQueryParameter

Expand Down