Remove CreateIfMissing option#4654
Closed
chemelnucfin wants to merge 2 commits intogoogleapis:masterfrom
Closed
Conversation
googlebot
added
the
cla: yes
chemelnucfin
force-pushed
the
firestore-create_if_missing
branch
from
a5a2f5a to
3471f13
Compare
dhermes
reviewed
Jan 2, 2018
Contributor
dhermes
left a comment
dhermes
left a comment
There was a problem hiding this comment.
This seems mostly OK but I worry that we are replacing CreateIfMissing with Exists in places where they aren't fully equivalent.
| write_pb = write_pb2.Write(delete=document_path) | ||
| if option is not None: | ||
| option.modify_write(write_pb, no_create_msg=NO_CREATE_ON_DELETE) | ||
| option.modify_write(write_pb) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| :meth:`~.DocumentReference.delete`. | ||
|
|
||
| Exactly one of three keyword arguments must be provided: | ||
| One of the following two keyword arguments must be provided: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| 'yum': _value_pb(bytes_value=value), | ||
| }) | ||
| if isinstance(option, ExistsOption): | ||
| write_kwargs = {'current_document' : {'exists': option._exists}} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
chemelnucfin
force-pushed
the
firestore-create_if_missing
branch
from
3471f13 to
7758dbe
Compare
chemelnucfin
added
the
type: feature request
chemelnucfin
force-pushed
the
firestore-create_if_missing
branch
from
7758dbe to
bd67ea7
Compare
chemelnucfin
force-pushed
the
firestore-create_if_missing
branch
from
bd67ea7 to
4024fcb
Compare
This was referenced Feb 7, 2018
Closed
chemelnucfin
changed the title
Contributor
Author
|
Closing this pull request The commits are in #4851 and can be reviewed commit by commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial #4111