Removing googleapis-common-protos from deps in non-core packages.#4098
Merged
dhermes merged 3 commits intogoogleapis:masterfrom Oct 4, 2017
Merged
Removing googleapis-common-protos from deps in non-core packages.#4098dhermes merged 3 commits intogoogleapis:masterfrom
googleapis-common-protos from deps in non-core packages.#4098dhermes merged 3 commits intogoogleapis:masterfrom
Conversation
dhermes
requested review from
duggelz,
liyanhui1228,
lukesneeringer,
tseaver and
waprin
as code owners
googlebot
added
the
cla: yes
dhermes
removed request for
duggelz,
liyanhui1228,
lukesneeringer,
tseaver and
waprin
tseaver
reviewed
Oct 2, 2017
Contributor
tseaver
left a comment
tseaver
left a comment
There was a problem hiding this comment.
This makes grpcio an unconditional dependency for all APIs, even storage which is otherwise REST-only. Is that what we want?
Contributor
Author
|
@tseaver It already was, this is the line being removed from |
Contributor
Contributor
Author
|
Ahh good call. That was some extra fail copy-pasta by me in #4096. |
Contributor
|
ISTM that adding unconditional dependencies to an already-GA API should be worth some debate. |
Contributor
Author
Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`)
dhermes
force-pushed
the
update-grpcio-deps
branch
from
b94db82 to
d5a4c51
Compare
Contributor
Author
|
@tseaver PTAL, I made @jonparrott Does this look like the right approach for packaging? |
dhermes
force-pushed
the
update-grpcio-deps
branch
from
d5a4c51 to
60a1798
Compare
dhermes
commented
Oct 3, 2017
| install_requires=( | ||
| 'googleapis-common-protos >= 1.5.3, < 2.0dev', | ||
| 'google-gax >= 0.15.14, < 0.16dev', | ||
| 'grpcio >= 1.2.0, < 1.6dev', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Oct 4, 2017
tseaver
approved these changes
Oct 4, 2017
Contributor
tseaver
left a comment
tseaver
left a comment
There was a problem hiding this comment.
The grpc extra (and depending on it from the grpc-only API packages) looks right to me.
Contributor
Author
|
@lukesneeringer Can you follow-up on my question (#4098 (comment)) when you get a chance? |
Closed
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
…#4098) * Removing `googleapis-common-protos` from deps in non-`core` packages. Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`) * Making `grpc` an extra for `core`. * Adding `googleapis-common-protos` back to `videointelligence`.
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
…#4098) * Removing `googleapis-common-protos` from deps in non-`core` packages. Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`) * Making `grpc` an extra for `core`. * Adding `googleapis-common-protos` back to `videointelligence`.
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
…#4098) * Removing `googleapis-common-protos` from deps in non-`core` packages. Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`) * Making `grpc` an extra for `core`. * Adding `googleapis-common-protos` back to `videointelligence`.
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
…#4098) * Removing `googleapis-common-protos` from deps in non-`core` packages. Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`) * Making `grpc` an extra for `core`. * Adding `googleapis-common-protos` back to `videointelligence`.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…#4098) * Removing `googleapis-common-protos` from deps in non-`core` packages. Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`) * Making `grpc` an extra for `core`. * Adding `googleapis-common-protos` back to `videointelligence`.
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
…#4098) * Removing `googleapis-common-protos` from deps in non-`core` packages. Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`) * Making `grpc` an extra for `core`. * Adding `googleapis-common-protos` back to `videointelligence`.
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
…#4098) * Removing `googleapis-common-protos` from deps in non-`core` packages. Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`) * Making `grpc` an extra for `core`. * Adding `googleapis-common-protos` back to `videointelligence`.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…#4098) * Removing `googleapis-common-protos` from deps in non-`core` packages. Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`) * Making `grpc` an extra for `core`. * Adding `googleapis-common-protos` back to `videointelligence`.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…#4098) * Removing `googleapis-common-protos` from deps in non-`core` packages. Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`) * Making `grpc` an extra for `core`. * Adding `googleapis-common-protos` back to `videointelligence`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also
grpciofrom non-corepackages.grpciodep in core (rather than getting it fromgoogleapis-common-protos[grpc])(NOTE: This is a followup to #4096.)