Retry streaming exceptions (this time for sure, Rocky!)#4016
Merged
Conversation
Tracks the 'resume_token', and issues restart after a 503.
Retry handling will be done behind the scenes.
tseaver
added
api: spanner
googlebot
added
the
cla: yes
Contributor
Author
theacodes
approved these changes
Sep 21, 2017
Contributor
|
After @vkedia says yes, I will start the process for a Spanner release. |
|
Thanks @lukesneeringer, @tseaver, and @jonparrott! |
vkedia
reviewed
Sep 21, 2017
spanner/tests/unit/test_snapshot.py
Outdated
| LAST = ( | ||
| self._make_item(3), | ||
| ) | ||
| ITEMS = FIRST + SECOND + LAST |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
vkedia
reviewed
Sep 21, 2017
| self.assertEqual(list(resumable), list(ITEMS)) | ||
| restart.assert_called_once_with() | ||
|
|
||
| def test_iteration_w_raw_raising_unavailable(self): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also, remove unused variable. Addresses: #4016 (comment) #4016 (comment)
Contributor
|
Is this approved, @vkedia? |
vkedia
approved these changes
Sep 21, 2017
tseaver
deleted the
3775-spanner-retry-streaming-exceptions-bullwinkle
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3930.
Closes #3775.
/cc vkedia