Skip to content

Trace logs correlation docs for logging-{winston,bunyan} #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 2 commits into from
Oct 3, 2017
Merged

Trace logs correlation docs for logging-{winston,bunyan} #2630

stephenplusplus merged 2 commits into from
Oct 3, 2017

Conversation

@draffensperger
Copy link
Contributor

@draffensperger draffensperger commented Sep 26, 2017

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2017
@coveralls
Copy link

coveralls commented Sep 26, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8d49298 on draffensperger:logging-trace-readme into e1f075a on GoogleCloudPlatform:master.

kjin
kjin reviewed Oct 2, 2017
View reviewed changes
packages/logging-winston/README.md Outdated

![Logs in Trace Example](/packages/logging-winston/doc/images/winston-logs-in-trace.png)

If you wish to set the LogEntry `trace` property with a custom value, then set a winston metadata property for `'logging.googleapis.com/trace'`, which is exported by this module as `LOGGING_TRACE_KEY`.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented Oct 2, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 987c190 on draffensperger:logging-trace-readme into e1f075a on GoogleCloudPlatform:master.

kjin
kjin approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my end

@stephenplusplus stephenplusplus merged commit 3ebaf5c into googleapis:master Oct 3, 2017
@draffensperger draffensperger deleted the logging-trace-readme branch October 3, 2017 14:05
@renovate renovate bot mentioned this pull request Feb 2, 2018
Merged
This was referenced Jan 14, 2026
Closed
Closed
Closed
@GautamSharda GautamSharda mentioned this pull request Jan 21, 2026
Closed
4 tasks
This was referenced Feb 2, 2026
Closed
Merged
This was referenced Feb 4, 2026
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

1 more reviewer

@kjin kjin kjin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: logging-bunyan api: logging-winston cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@draffensperger @coveralls @kjin @stephenplusplus @googlebot