error-reporting: Address unresponsive Hapi apps#2315
Merged
stephenplusplus merged 3 commits intogoogleapis:masterfrom May 18, 2017
Merged
error-reporting: Address unresponsive Hapi apps#2315stephenplusplus merged 3 commits intogoogleapis:masterfrom
stephenplusplus merged 3 commits intogoogleapis:masterfrom
Conversation
The Hapi plugin was too restrictive when determining if it should continue a reply, which could cause some Hapi apps to become unresponsive.
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 1427e45 on DominicKramer:bug/fix-hapi-unresponsive into ** on GoogleCloudPlatform:master**. |
ofrobots
suggested changes
May 17, 2017
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
The change looks good, but please add a test for this. Were we missing a test, or how was it passing?
Contributor
Author
|
I've added a test. It looks like we thought that the However, I made a Hapi app and found that it is possible that |
|
Changes Unknown when pulling 92ec62a on DominicKramer:bug/fix-hapi-unresponsive into ** on GoogleCloudPlatform:master**. |
ofrobots
approved these changes
May 17, 2017
| }); | ||
| it('Should call continue when a boom is emitted', function(done) { | ||
| it('Should call continue when a boom is emitted if reply is an object', | ||
| function(done) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| ); | ||
| }); | ||
| it('Should call continue when a boom is emitted if reply is a function', | ||
| function(done) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling 8b43f0a on DominicKramer:bug/fix-hapi-unresponsive into ** on GoogleCloudPlatform:master**. |
Contributor
Author
|
@stephenplusplus This is ready to land. |
This was referenced Jul 5, 2017
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
* error-reporting: Address unresponsive Hapi apps The Hapi plugin was too restrictive when determining if it should continue a reply, which could cause some Hapi apps to become unresponsive.
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
* error-reporting: Address unresponsive Hapi apps The Hapi plugin was too restrictive when determining if it should continue a reply, which could cause some Hapi apps to become unresponsive.
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 5, 2026
* error-reporting: Address unresponsive Hapi apps The Hapi plugin was too restrictive when determining if it should continue a reply, which could cause some Hapi apps to become unresponsive.
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 23, 2026
* error-reporting: Address unresponsive Hapi apps The Hapi plugin was too restrictive when determining if it should continue a reply, which could cause some Hapi apps to become unresponsive.
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
* feat: Transfer Manager Metrics * fix: Add missing `gccl-gcs-cmd/` prefix * fix: remove unused method * refactor: update logic for both headers * refactor: use `Symbol.for` in case the file is evaluated multiple times * fix: add missing URL param * fix: if header doesn't exist, add it * test: Add `GCCL_GCS_CMD_KEY` TM tests * feat: Add base `x-goog-api-client` for XML API * chore: dep type change * fix: pass `GCCL_GCS_CMD_KEY` * refactor: remove unused * test: Add `GCCL_GCS_CMD` tests * chore: cleanup * build: Support Source Maps for Local Debugging * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
* feat(spanner): add new change_stream.proto PiperOrigin-RevId: 766241102 Source-Link: googleapis/googleapis@2bea1fc Source-Link: googleapis/googleapis-gen@f429e2a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjQyOWUyYTg2NDkyZmUzNzc1NDA3OWZmMDIzNmNiYWMzYmUxYmZiYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
🤖 I have created a release *beep* *boop* --- ## [8.1.0](https://github.com/googleapis/nodejs-spanner/compare/v8.0.0...v8.1.0) (2025-07-28) ### Features * Add Custom OpenTelemetry Exporter in for Service Metrics ([#2272](https://github.com/googleapis/nodejs-spanner/issues/2272)) ([610d1b9](https://github.com/googleapis/nodejs-spanner/commit/610d1b989ba186c0758791343deaa7f683c4bd26)) * Add methods from gax to cache proto root and process custom error details ([#2330](https://github.com/googleapis/nodejs-spanner/issues/2330)) ([1b3931a](https://github.com/googleapis/nodejs-spanner/commit/1b3931a799bdd052adc91703e59e1d0c83270065)) * Add metrics tracers ([#2319](https://github.com/googleapis/nodejs-spanner/issues/2319)) ([192bf2b](https://github.com/googleapis/nodejs-spanner/commit/192bf2bb603bca4ac481fcfd1f04974173adc6a1)) * Add support for AFE latency metrics ([#2348](https://github.com/googleapis/nodejs-spanner/issues/2348)) ([0666f05](https://github.com/googleapis/nodejs-spanner/commit/0666f05d589e2f229b44dffae8e9649220bccf8b)) * Add throughput_mode to UpdateDatabaseDdlRequest to be used by Spanner Migration Tool. See https://github.com/GoogleCloudPlatform/spanner-migration-tool ([#2304](https://github.com/googleapis/nodejs-spanner/issues/2304)) ([a29af56](https://github.com/googleapis/nodejs-spanner/commit/a29af56ae3c31f07115cb938bcf3f0f77241b725)) * Operation, Attempt, and GFE metrics ([#2328](https://github.com/googleapis/nodejs-spanner/issues/2328)) ([646e6ea](https://github.com/googleapis/nodejs-spanner/commit/646e6ea6f1dc5fa1937e512ae9e81ae4d2637ed0)) * Proto changes for an internal api ([#2356](https://github.com/googleapis/nodejs-spanner/issues/2356)) ([380e770](https://github.com/googleapis/nodejs-spanner/commit/380e7705a23a692168db386ba5426c91bf1587b6)) * **spanner:** A new field `snapshot_timestamp` is added to message `.google.spanner.v1.CommitResponse` ([#2350](https://github.com/googleapis/nodejs-spanner/issues/2350)) ([0875cd8](https://github.com/googleapis/nodejs-spanner/commit/0875cd82e99fa6c95ab38807e09c5921303775f8)) * **spanner:** Add new change_stream.proto ([#2315](https://github.com/googleapis/nodejs-spanner/issues/2315)) ([57d67be](https://github.com/googleapis/nodejs-spanner/commit/57d67be2e3b6d6ac2a8a903acf8613b27a049c3b)) * **spanner:** Add tpc support ([#2333](https://github.com/googleapis/nodejs-spanner/issues/2333)) ([a381cab](https://github.com/googleapis/nodejs-spanner/commit/a381cab92c31373a6a10edca0f8a8bdfc4415e4b)) * Track precommit token in r/w apis(multiplexed session) ([#2312](https://github.com/googleapis/nodejs-spanner/issues/2312)) ([3676bfa](https://github.com/googleapis/nodejs-spanner/commit/3676bfa60725c43f85a04ead87943be92e4a99f0)) ### Bug Fixes * Docs-test ([#2297](https://github.com/googleapis/nodejs-spanner/issues/2297)) ([61c571c](https://github.com/googleapis/nodejs-spanner/commit/61c571c729c2a065df6ff166db784a6e6eaef74d)) * Ensure context propagation works in Node.js 22 with async/await ([#2326](https://github.com/googleapis/nodejs-spanner/issues/2326)) ([e8cdbed](https://github.com/googleapis/nodejs-spanner/commit/e8cdbedd55f049b8c7766e97388ed045fedd1b4e)) * Pass the Span correctly ([#2332](https://github.com/googleapis/nodejs-spanner/issues/2332)) ([edaee77](https://github.com/googleapis/nodejs-spanner/commit/edaee7791b2d814f749ed35119dd705924984a78)) * System test against emulator ([#2339](https://github.com/googleapis/nodejs-spanner/issues/2339)) ([2a6af4c](https://github.com/googleapis/nodejs-spanner/commit/2a6af4c36484f44929a2fac80d8f225dad5d702c)) * Unhandled exceptions from gax ([#2338](https://github.com/googleapis/nodejs-spanner/issues/2338)) ([6428bcd](https://github.com/googleapis/nodejs-spanner/commit/6428bcd2980852c1bdbc4c3d0ab210a139e5f193)) ### Performance Improvements * Skip gRPC trailers for StreamingRead & ExecuteStreamingSql ([#2313](https://github.com/googleapis/nodejs-spanner/issues/2313)) ([8bd0781](https://github.com/googleapis/nodejs-spanner/commit/8bd0781e8b434a421f0e0f3395439a5a86c7847c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hapi plugin was too restrictive when determining if it should
continue a reply, which could cause some Hapi apps to become
unresponsive.