Skip to content

Conversation

@stephenplusplus
Copy link
Contributor

No description provided.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@stephenplusplus
Copy link
Contributor Author

Instead of all of this, how about just remove the _ from the constructor's this.namespace_ and this.path_?

@stephenplusplus
Copy link
Contributor Author

We can drop this PR in favor of stephenplusplus@9667465 if we don't see ourselves needing to re-assign path or namespace.

sofisl pushed a commit that referenced this pull request Sep 15, 2022
sofisl pushed a commit that referenced this pull request Sep 16, 2022
sofisl pushed a commit that referenced this pull request Oct 5, 2022
sofisl pushed a commit that referenced this pull request Oct 5, 2022
sofisl pushed a commit that referenced this pull request Oct 8, 2022
miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
GautamSharda pushed a commit that referenced this pull request Jan 15, 2026
sofisl pushed a commit that referenced this pull request Jan 27, 2026
sofisl pushed a commit that referenced this pull request Jan 27, 2026
sofisl pushed a commit that referenced this pull request Feb 3, 2026
Fixes #174
Closes #173 

- [x] Tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

The original issue being addressed (#174) was remedied by simply upgrading the common package. However additional bugs were identified after that were introduced via #85. A second commit to fix said bug was created.
GautamSharda pushed a commit that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants