Skip to content

testing: remove common require from snippet test running#1615

Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:snippet-test-util
Sep 23, 2016
Merged

testing: remove common require from snippet test running#1615
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:snippet-test-util

Conversation

@callmehiphop
Copy link
Contributor

No description provided.

@callmehiphop callmehiphop added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. docs labels Sep 23, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2016
@stephenplusplus stephenplusplus merged commit 7246dd6 into googleapis:master Sep 23, 2016
sofisl pushed a commit that referenced this pull request Feb 25, 2026
* feat: added library methods for conformance testing (#1553)

* feat: added library methods for conformance testing

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fixed header

* responded to PR comment, addressed some TODOs

* resolved TODO

* removed functions that dont make requests

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: add method mapping json file (#1569)

* feat: add method mapping json file

* add deleteResumableCache to mapping

* WIP: retry strategy runner code (#1567)

* feat: retry strategy runner code

* fixed license

* removed unused option

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* built out tests further, still doesnt work

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* built out more functionality

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* began refactor

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* moved functions

* refactored code

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update libraryMethods.ts

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: fixed runtime errors. all the tests still fail, but they run now (#1591)

* fix: fixed runtime errors. all the tests still fail, but they run now

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: exported functions

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: pull testbench docker image, kokoro presubmit conformance test … (#1590)

* test: pull testbench docker image, kokoro presubmit conformance test hooks

* use async function instead of explicit promise return

* move file to node12 directory

* fix file naming and linter issues

* fix: retry strategy bug fixes (#1594)

* bug fixes

* removed logs

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* some tests pass

* fixed some more tests

* saves file

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* uncommented functions

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* removed duplicate storage definition

* changed precondition options

* down to 7 failing tests!

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: check that instructions were utilized in testbench (#1601)

* feat: check that instructions were utilized in testbench

* feedback

* fix: remove all files from bucket before delete (#1603)

* feat: move test creation and header set to beforeEach (#1605)

* feat: move test creation and header set to beforeEach

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: create client for each test instead of globally (#1608)

* fix: remove bucketGet (#1610)

* fix: return promise from stream functions and resolve on end (#1612)

* fix: move createReadStream to correct mapping location (#1613)

* fix: remap bucket set storage class and bucket set metadata (#1615)

* fix: remap bucket set storage class

* fix: remap bucketSetMetadata

* fix: fixed bucketUploadMultipart (#1627)

* fix: fixed bucketUploadMultipart

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: conformance test fixes for deleteFiles, fileDelete, and copy (#1636)

* fix: add copy to invocation map

* fix: fix deleteFiles and fileDelete conformance tests

* linter fixes

* fix: only send metageneration to bucket related tests (#1641)

* fix: remove tests for createWriteStream as the function is not retryable

* fix: only send metageneration to bucket related tests

* linter

* fix: set retention period before file creation (#1651)

* set retention period before file creation

* removed log statement

* removed log statement

* fix: set correct bucket precondition (#1653)

* fix: set correct bucket precondition

* Update retryStrategy.ts

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: combine conformance test (#1656)

* fix: update test bucket (#1657)

* fix: combine conformance test

* fix: only return bucket with preconditions if the test says so

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: fixed storage.objects.patch tests (#1658)

* fix: fixed storage.objects.patch tests

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: refactor tests (#1659)

* fix: refactor tests

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: build headers for isPublic from interceptors (#1665)

* chore: build headers for isPublic from interceptors

* simplify code

* tests: removed failing tests (internal issue b/203793664) (#1674)

* fix: add conformance project id (#1673)

* fix: add conformance test project id settting

* lint

* increase timeout for before hook

* specify correct host to docker port mapping

* add stop command for docker container

* chore: use import on json files instead of fs read (#1675)

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
sofisl pushed a commit that referenced this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants