Conversation
googlebot
added
the
cla: yes
| } | ||
|
|
||
| if (listInstancesResponse.getFailedLocationsList().size() > 0) { | ||
| throw new FailedLocationException("Failed to list all locations", succeededLocations, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| import com.google.protobuf.FieldMask; | ||
|
|
||
| @BetaApi | ||
| public final class InstanceAdminRequests { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| .getPermissionsList(); | ||
| } | ||
|
|
||
| /** compose proto request helpers * */ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return appProfiles; | ||
| } | ||
|
|
||
| /** Can be removed after https://github.com/googleapis/gax-java/issues/552 is handled */ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return new CreateInstance(projectName, instance, cluster); | ||
| } | ||
|
|
||
| public static Instance convertToInstance(com.google.bigtable.admin.v2.Instance protoInstance) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| protoUpdateProfile.setMultiClusterRoutingUseAny( | ||
| com.google.bigtable.admin.v2.AppProfile.MultiClusterRoutingUseAny.newBuilder().build()); | ||
| protoUpdateProfile.clearSingleClusterRouting(); | ||
| replacefields.add(MULTI_CLUSTER_FIELDMASK); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| public static class UpdateAppProfile { | ||
| private static final String DESCRIPTION_FIELDMASK = "description"; | ||
| private static final String MULTI_CLUSTER_FIELDMASK = "multi_cluster_routing_use_any"; | ||
| private static final String SINGLE_CLUSTER__FIELDMASK = "single_cluster_routing"; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| RoutingPolicyCase name(); | ||
| } | ||
|
|
||
| public static class RoutingPolicyNotSet implements RoutingPolicy { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
|
|
||
| public RoutingPolicy getRoutingPolicy() { | ||
| if (RoutingPolicyCase.MULTI_CLUSTER_ROUTING_USE_ANY |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| public static final class Policy { | ||
| private com.google.iam.v1.Policy.Builder protoPolicy = com.google.iam.v1.Policy.newBuilder(); | ||
|
|
||
| public static Policy of(int version, Role role, List<String> members) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@kevinsi4508 can you take a look as well? |
|
I am going to take a look at high level. |
|
A few concerns:
|
|
@spollapally thanks for all of your work. I've broken up this PR into: So I'm going to close this now |
|
Thanks Igor.
…-Sudharshan
On Thu, Aug 30, 2018 at 5:59 PM, Igor Bernstein ***@***.***> wrote:
Closed #3497
<#3497>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3497 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfisGOqjKhnAeNOjqsjmNi5-bSTOjf7wks5uWGAwgaJpZM4VcC4L>
.
|
4 participants
For model review. Needs documentation, unit tests and cleanup.