Standardize IAM method names in Google Cloud Storage#1906
Merged
garrettjonesgoogle merged 2 commits intogoogleapis:storage-iamfrom Apr 13, 2017
Merged
Standardize IAM method names in Google Cloud Storage#1906garrettjonesgoogle merged 2 commits intogoogleapis:storage-iamfrom
garrettjonesgoogle merged 2 commits intogoogleapis:storage-iamfrom
Conversation
IAM methods in the public APIs are named getIamPolicy, setIamPolicy and testIamPermissions. Standardizing on these will reduce cognitive overhead.
googlebot
added
the
cla: yes
Member
|
LGTM |
Member
|
Looks like your change caused a compile error in FakeStorageRpc. |
Member
|
Easy way to build & run unit tests locally (skipping integration tests):
|
|
Changes Unknown when pulling 3c6cfe6 on rybosome:storage-iam into ** on GoogleCloudPlatform:storage-iam**. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IAM methods in the public APIs are named getIamPolicy, setIamPolicy and
testIamPermissions. Standardizing on these will reduce cognitive overhead.