Add convenience method to get a Path to a file whose name includes spaces by jean-philippe-martin · Pull Request #1463 · googleapis/google-cloud-java

jean-philippe-martin · 2016-12-08T20:14:17Z

Also add tests to make sure spaces are handled correctly (they are).

...d-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProvider.java

coveralls · 2016-12-08T22:47:56Z

Coverage increased (+0.002%) to 83.53% when pulling b157814 on jean-philippe-martin:jp_spaces into 27962a3 on GoogleCloudPlatform:master.

...o/src/test/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProviderTest.java

...oogle-cloud-nio/src/test/java/com/google/cloud/storage/contrib/nio/CloudStoragePathTest.java

garrettjonesgoogle · 2017-02-23T01:52:09Z

@jean-philippe-martin is the feedback on this PR going to be addressed or should we close it out?

jean-philippe-martin · 2017-02-23T14:12:27Z

@garrettjonesgoogle terribly sorry, the email must have gotten lost somehow! I'll get to it today.

jean-philippe-martin · 2017-03-06T21:19:56Z

Rebased to hopefully get rid of conflict.

coveralls · 2017-03-07T01:39:18Z

Coverage increased (+0.01%) to 81.215% when pulling 0757985 on jean-philippe-martin:jp_spaces into bf8df09 on GoogleCloudPlatform:master.

...o/src/test/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProviderTest.java

coveralls · 2017-03-10T23:16:03Z

Changes Unknown when pulling f9fd9a1 on jean-philippe-martin:jp_spaces into ** on GoogleCloudPlatform:master**.

garrettjonesgoogle · 2017-03-11T00:09:35Z

Looks like you'll need to resolve merge conflicts before we can merge.

spaces. Also add tests to make sure spaces are handled correctly (they are).

jean-philippe-martin · 2017-03-11T00:45:01Z

Indeed, thank you. Conflict resolved.

...o/src/test/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProviderTest.java

coveralls · 2017-03-11T01:22:24Z

Changes Unknown when pulling ba248b0 on jean-philippe-martin:jp_spaces into ** on GoogleCloudPlatform:master**.

jean-philippe-martin · 2017-03-11T01:34:53Z

Yay, thank you! Have a great weekend!

🤖 I have created a release *beep* *boop* --- ## [2.3.8](googleapis/java-bigquerydatatransfer@v2.3.7...v2.3.8) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1462](googleapis/java-bigquerydatatransfer#1462)) ([098a820](googleapis/java-bigquerydatatransfer@098a820)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…to v3.15.12 (#1463) * chore(deps): update dependency com.google.cloud:google-cloud-logging to v3.15.12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…2.2 (#1463) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-logging](https://redirect.github.com/googleapis/java-logging) | `3.22.1` -> `3.22.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud:google-cloud-logging/3.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud:google-cloud-logging/3.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud:google-cloud-logging/3.22.1/3.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud:google-cloud-logging/3.22.1/3.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.22.2`](https://redirect.github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3222-2025-04-25) [Compare Source](https://redirect.github.com/googleapis/java-logging/compare/v3.22.1...v3.22.2) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.46.2 ([#1796](https://redirect.github.com/googleapis/java-logging/issues/1796)) ([1f88271](https://redirect.github.com/googleapis/java-logging/commit/1f882712aeb7e48a2339ffbad783813e11e74401)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/java-logging-logback).

…e to v2.20.0 (#1463) * chore(deps): update dependency com.google.cloud:google-cloud-datastore to v2.20.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2016

Horneth reviewed Dec 8, 2016

View reviewed changes

...d-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProvider.java Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

garrettjonesgoogle reviewed Jan 11, 2017

View reviewed changes

jean-philippe-martin force-pushed the jp_spaces branch 2 times, most recently from 5819685 to 78c72c7 Compare February 23, 2017 23:46

jean-philippe-martin force-pushed the jp_spaces branch from 78c72c7 to 0757985 Compare March 6, 2017 21:19

jean-philippe-martin mentioned this pull request Mar 10, 2017

Update google-cloud-java dependency to a snapshot containing newly added NIO API methods broadinstitute/gatk#2441

Closed

garrettjonesgoogle reviewed Mar 10, 2017

View reviewed changes

jean-philippe-martin added 5 commits March 10, 2017 16:43

Add convenience method to get a Path to a file whose name includes

2de1df5

spaces. Also add tests to make sure spaces are handled correctly (they are).

remove unused import

8aeb4e3

bugfix and add test for %

6ab95f8

reviewer and linter comments

af97ba8

Reviewer comments

1b8f3c2

jean-philippe-martin force-pushed the jp_spaces branch from f9fd9a1 to 1b8f3c2 Compare March 11, 2017 00:44

garrettjonesgoogle reviewed Mar 11, 2017

View reviewed changes

...o/src/test/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProviderTest.java Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Fix test

ba248b0

garrettjonesgoogle merged commit 6d844c9 into googleapis:master Mar 11, 2017

jean-philippe-martin deleted the jp_spaces branch March 11, 2017 01:34

Conversation

jean-philippe-martin commented Dec 8, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Dec 8, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Feb 23, 2017

Uh oh!

jean-philippe-martin commented Feb 23, 2017

Uh oh!

jean-philippe-martin commented Mar 6, 2017

Uh oh!

coveralls commented Mar 7, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Mar 10, 2017

Uh oh!

garrettjonesgoogle commented Mar 11, 2017

Uh oh!

jean-philippe-martin commented Mar 11, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Mar 11, 2017

Uh oh!

jean-philippe-martin commented Mar 11, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments