-
Notifications
You must be signed in to change notification settings - Fork 441
chore: update conformance test #3980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
google/cloud/storage/tests/signed_url_conformance_test.cc, line 120 at r1 (raw file):
} std::string const date = j_obj["timestamp"]; auto const valid_for = std::chrono::seconds(j_obj["expiration"].get<int>());
FYI, there is a helper function (internal::ParseIntField()) that parses JSON fields that can be an int or a std::string with a number inside.
Codecov Report
@@ Coverage Diff @@
## master #3980 +/- ##
==========================================
+ Coverage 93.89% 93.92% +0.03%
==========================================
Files 645 645
Lines 48815 48821 +6
==========================================
+ Hits 45833 45856 +23
+ Misses 2982 2965 -17
Continue to review full report at Codecov.
|
This fixes googleapis#3943. Update to commit googleapis/conformance-tests@dfdfff5
dopiera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 5 files reviewed, all discussions resolved (waiting on @coryan)
google/cloud/storage/tests/signed_url_conformance_test.cc, line 120 at r1 (raw file):
Previously, coryan (Carlos O'Ryan) wrote…
FYI, there is a helper function (
internal::ParseIntField()) that parses JSON fields that can be anintor astd::stringwith a number inside.
I didn't notice this, thanks. Change for mor futureproofness.
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
This fixes #3943.
Update to commit
googleapis/conformance-tests@dfdfff5
This change is