Skip to content

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Feb 9, 2026

This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner February 9, 2026 23:25
@scotthart scotthart requested a review from coryan February 9, 2026 23:25
@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the v3 migration guide documentation by reorganizing content related to build system changes and decommissioned API surfaces. The changes aim to improve clarity and structure, making it easier for users to navigate information about Bazel module integration and specific header file removals.

Highlights

  • Documentation Restructuring: The 'Bazel Central Registry' section was relocated and encapsulated within a collapsible details block under a new 'Build system changes' heading for better organization.
  • Dependency Clarification: The description for the crc32c dependency was updated to specify its distribution as part of Abseil.
  • Decommissioned API Surfaces: A new top-level section 'Decommissioned API Surfaces' was introduced, and the removal of the iam/retry_traits.h file was moved and documented within this new section.
Changelog
  • doc/v3-migration-guide.md
    • Relocated the 'Bazel Central Registry' section to a new 'Build system changes' heading and wrapped it in a collapsible details block.
    • Updated the description for the crc32c dependency to note its inclusion in Abseil.
    • Introduced a new top-level section titled 'Decommissioned API Surfaces'.
    • Moved and documented the removal of the iam/retry_traits.h file under the new 'Decommissioned API Surfaces' section.
    • Removed a duplicate entry for the iam/retry_traits.h file removal.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the v3 migration guide by reorganizing sections for better clarity and adding information about decommissioned APIs. The changes are well-structured and make the guide easier to follow. I have one minor suggestion to improve the grammar in one of the updated lines.

### Relocated Dependencies

- `crc32c`
- `crc32c` Is now distributed as part of Abseil.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better grammar, the sentence should start with a lowercase letter as it is part of a bulleted list item.

Suggested change
- `crc32c` Is now distributed as part of Abseil.
- `crc32c` is now distributed as part of Abseil.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.62%. Comparing base (6d0f68d) to head (9778333).
⚠️ Report is 2 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           prepare-for-v3.0.0   #15950   +/-   ##
===================================================
  Coverage               92.61%   92.62%           
===================================================
  Files                    2332     2332           
  Lines                  213322   213322           
===================================================
+ Hits                   197568   197587   +19     
+ Misses                  15754    15735   -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions in style. I like the use of <details>. The guide is not too long, but provides more information where needed.

"The passive voice should never be used"

### Relocated Dependencies

- `crc32c`
- `crc32c` Is now distributed as part of Abseil.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure you need to say that? Maybe just "google-cloud-cpp now uses the crc32c implementation in Abseil"? I am not sure it matters that the implementation is distributed with Abseil or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

### Bazel

<details>
<summary>google-cloud-cpp module in Bazel Central Registry</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you still supporting customers with workspaces? If not, just say that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to describe WORKSPACE support going forward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/the CMakeLists.txt/your CMakeLists.txt`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/The deprecated /The deprecated class / ?

PS: you know I do not like the passive voice. "We removed the bigtable::ClientOptions class in this release. We had deprecated this class in ...".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment on lines 499 to 500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As opposed to the counterfeit migration guide? Just say "migration guide".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@scotthart
Copy link
Member Author

I made a lot of edits to switch from passive voice to active voice.

new API surfaces that supersede the previous deprecated types and functions. As
part of the v3 release series, we are decommissioning those deprecated API
surfaces. This guide serves a central location to document how to migrate from
surfaces. This guide provides a central location to document how to migrate from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we repeating things?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded.

@scotthart scotthart force-pushed the v3_clean_migration_guide branch from eb70ac5 to 9778333 Compare February 10, 2026 20:06
@scotthart scotthart merged commit 2d1b10a into googleapis:prepare-for-v3.0.0 Feb 10, 2026
57 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants