Skip to content

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Feb 9, 2026

This leverages vcpkg and is thus constrained by which versions of dependencies are available.


This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner February 9, 2026 21:48
@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the cmake-oldest-deps build by migrating its CI environment to Ubuntu 22.04 and updating a wide array of C++ library dependencies to their latest compatible versions via vcpkg. These changes aim to ensure the build remains current with upstream libraries and operating system versions, while also introducing flexibility to manage specific emulator tests.

Highlights

  • Dependency Version Updates: Significant updates to core C++ library dependencies like gRPC, Protobuf, OpenTelemetry-CPP, and GTest within the vcpkg.json configuration, along with the addition of utf8-range and re2.
  • Ubuntu 22.04 Migration: The cmake-oldest-deps build environment has been upgraded from Ubuntu Focal to Ubuntu 22.04, including the addition of a new Dockerfile for the new distribution.
  • Spanner Emulator Test Skipping: The CI script now supports conditionally skipping Spanner emulator tests, which is currently enabled for the cmake-oldest-deps build.
Changelog
  • ci/cloudbuild/builds/cmake-oldest-deps.sh
    • Added a comment and argument to skip Spanner emulator tests.
  • ci/cloudbuild/builds/lib/integration.sh
    • Modified integration::ctest_with_emulators to accept and process arguments for skipping specific emulator tests.
    • Wrapped Spanner emulator test execution in a conditional check based on skip arguments.
  • ci/cloudbuild/dockerfiles/ubuntu-22.04.Dockerfile
    • Introduced a new Dockerfile for Ubuntu 22.04, configuring essential build tools, Python, Java, Cloud SDK, and Bazelisk.
  • ci/cloudbuild/triggers/cmake-oldest-deps-ci.yaml
    • Updated the build trigger to use ubuntu-22.04 as the distribution.
  • ci/cloudbuild/triggers/cmake-oldest-deps-pr.yaml
    • Updated the build trigger to use ubuntu-22.04 as the distribution.
  • ci/etc/oldest-deps/vcpkg.json
    • Updated the project version to 3.0.0.
    • Removed crc32c dependency.
    • Updated grpc to 1.71.0 (from 1.33.1/1.36.4).
    • Updated protobuf to 5.29.5 (from 3.15.8).
    • Updated opentelemetry-cpp to 1.22.0 (from 1.20.0).
    • Updated gtest to 1.17.0 (from 1.11.0/1.12.0).
    • Added utf8-range and re2 dependencies and overrides.
    • Added benchmark override to 1.9.4.
Activity
  • The pull request description indicates that the changes are related to leveraging vcpkg for dependency management, acknowledging constraints imposed by available dependency versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the cmake-oldest-deps build to use ubuntu-22.04 and newer versions of dependencies via vcpkg. The changes also include a temporary workaround to skip Spanner integration tests. My review focuses on improving the robustness of the shell scripts and fixing issues in the new Dockerfile. I've identified a critical issue in the Dockerfile that would prevent the build from succeeding due to an undefined variable, along with a few medium-severity issues related to package installation and script correctness.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.62%. Comparing base (54b6476) to head (6c7f4f7).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           prepare-for-v3.0.0   #15948   +/-   ##
===================================================
  Coverage               92.61%   92.62%           
===================================================
  Files                    2332     2332           
  Lines                  213322   213322           
===================================================
+ Hits                   197573   197587   +14     
+ Misses                  15749    15735   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant