-
Notifications
You must be signed in to change notification settings - Fork 441
impl(v3): update cmake-oldest-deps build #15948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prepare-for-v3.0.0
Are you sure you want to change the base?
impl(v3): update cmake-oldest-deps build #15948
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the cmake-oldest-deps build to use ubuntu-22.04 and newer versions of dependencies via vcpkg. The changes also include a temporary workaround to skip Spanner integration tests. My review focuses on improving the robustness of the shell scripts and fixing issues in the new Dockerfile. I've identified a critical issue in the Dockerfile that would prevent the build from succeeding due to an undefined variable, along with a few medium-severity issues related to package installation and script correctness.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15948 +/- ##
===================================================
Coverage 92.61% 92.62%
===================================================
Files 2332 2332
Lines 213322 213322
===================================================
+ Hits 197573 197587 +14
+ Misses 15749 15735 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This leverages vcpkg and is thus constrained by which versions of dependencies are available.
This change is