apirequest/isReadableStream rework#335
Closed
viktorasm wants to merge 2 commits intogoogleapis:masterfrom
viktorasm:master
Closed
apirequest/isReadableStream rework#335viktorasm wants to merge 2 commits intogoogleapis:masterfrom viktorasm:master
viktorasm wants to merge 2 commits intogoogleapis:masterfrom
viktorasm:master
Conversation
…s readable stream, changing implementation to be less restrictive
Contributor
|
What part of that check is false? I just tried it with a raw http.IncomingMessage and seemed to work fine: > function isReadableStream(obj) { return obj instanceof stream.Stream && typeof obj._read === 'function' && typeof obj._readableState === 'object'; }
undefined
> var x = new http.IncomingMessage();
undefined
> isReadableStream(x);
true |
Contributor
|
Closing as I don't see a need for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried using a http.get response object directly as GCS media.body, which should be a valid readable stream.
Fixes #334