fix: Check for default value presence for non-optional fields in REST#868
Merged
vam-google merged 2 commits intogoogleapis:masterfrom May 7, 2021
Merged
fix: Check for default value presence for non-optional fields in REST#868vam-google merged 2 commits intogoogleapis:masterfrom
vam-google merged 2 commits intogoogleapis:masterfrom
Conversation
… transport Otherwise on practical cases we may get 400 errors because of empty body of the non-optional query params.
google-cla
bot
added
the
cla: yes
busunkim96
approved these changes
May 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1694 +86
Branches 328 347 +19
=========================================
+ Hits 1608 1694 +86
Continue to review full report at Codecov.
|
vam-google
changed the title
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise on practical cases we may get 400 errors because of empty body of the non-optional query params.