-
Notifications
You must be signed in to change notification settings - Fork 79
feat: Add support for reading MethodSettings from service configuration YAML #1975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
ecf0f97
feat: Add support for reading MethodSettings from service configurati…
parthea 16f3784
style
parthea 41c582c
refactor based on review feedback
parthea 9f5c5d5
refactor
parthea 884fda2
docs
parthea 12f4333
message->method_descriptor; update comments
parthea b12753d
update docstring of _check_service_yaml_validity
parthea 8d64606
typo
parthea b760a62
update docstring of _check_service_yaml_validity
parthea e7f8a02
grammar
parthea c3563c1
refactor for readability
parthea 8a9bbcb
refactor for readability
parthea dc7ac89
update comment
parthea 42cb7e8
mypy
parthea 1d03fb2
formatting
parthea 2499b59
update comment
parthea c55fa67
all_method_settings->service_method_settings
parthea 349735c
clean up
parthea 0c7d073
fix coverage
parthea bdf8b10
update comment
parthea 52b8d42
grammar
parthea af8e756
consolidate test cases
parthea 0c374ba
consolidate test cases
parthea 588d215
add test case
parthea 67335de
clean up
parthea 57493b0
fix test case
parthea 9f01b28
update test name
parthea 5a2d33b
address review feedback
parthea d5d0aee
style
parthea 73b06ca
fix typo
parthea 4161702
json->yaml
parthea e1c8785
json->yaml
parthea 04fa73e
SomeService->ServiceOne;AnotherService->ServiceTwo
parthea eac51b6
add test case for non-existent method
parthea 4d7b4ca
rename field in test_method_settings_auto_populated_field_not_found_r…
parthea 1ab06ea
add test case for nested field
parthea c05936a
Merge branch 'main' into add-support-for-method-settings
parthea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will overwrite any errors found the first time through the selector. It does seem like this is the more important error, but we might as well present all the errors found at once, which would mean appending (or maybe in this case prepending) to the previous list value in the map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If something wrong with the selector (it is a duplicate, doesn't map to a method or maps to a streaming method), I decided not to continue checking the validity of the auto-populated fields. The issue with the selector should be fixed and providing additional detail in the error message on the auto-populated fields would take away from the more important error with the selector.