Conversation
start updating tests.
|
Thanks for the PR! |
|
Hey @dbieber no worries, I use fire for a few projects so I'd love to contribute back! Also, I noticed the github action on my fork was failing because it couldn't find python 3.4 Only way I could get the build working was by removing 3.4, but I didn't include that in the pr. |
|
I've removed 3.4 from the CI now. Would be nice to add it back in if we can do so properly, but it's certainly not a priority. |
|
@dbieber cool, is there anything left I should change or is this ok to merge now? |
|
I'll do some cleanup when I merge it but unfortunately I won't get to that today. I'm also not sure why the CI tests didn't run on this PR... |
|
Cool no rush. Not sure about the CI either tbh, can you trigger it manually? Or can I do something on my end? |
|
Thanks for your patience. At long last, I've merged your PR and we'll include it in the next release. |
|
Thanks so much for following up! Really appreciate it |

Closes #317